Convert volume API from integers [0-128] to floats [0-1]#653
Closed
Starbuck5 wants to merge 6 commits intolibsdl-org:mainfrom
Closed
Convert volume API from integers [0-128] to floats [0-1]#653Starbuck5 wants to merge 6 commits intolibsdl-org:mainfrom
Starbuck5 wants to merge 6 commits intolibsdl-org:mainfrom
Conversation
mkunkacnc
reviewed
Dec 26, 2024
Contributor
Author
|
Coming back to this, I see it will be overcome-by-events by icculus's SDL_remixer, where volume is controlled by a *float* gain. So I will close this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a lot of places this actually makes the code simpler. Volumes can be multiplied without then dividing by the integer range, the new SDL3 mixing API can be used without another divide into float-land, it makes one or two music codecs more straightforward.
Closes #652
A couple things I wanted to highlight in review: