Skip to content

ci: add yasm patch#866

Open
madebr wants to merge 1 commit into
libsdl-org:SDL2from
madebr:sdl2-add-yasm-patch
Open

ci: add yasm patch#866
madebr wants to merge 1 commit into
libsdl-org:SDL2from
madebr:sdl2-add-yasm-patch

Conversation

@madebr

@madebr madebr commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

CMakeLists.txt from upstream yasm is not CMake 4.x compatible.

  • I confirm that I am the author of this code and release it to the SDL_mixer project under the Zlib license. This contribution does not contain code from other sources, including code generated by a Large Language Model ("AI").

@madebr madebr force-pushed the sdl2-add-yasm-patch branch from a2bec49 to 2398cab Compare June 13, 2026 17:35
@sezero

sezero commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

The following in yasm build stands out:

[78/127] Generating x86insn_gas.c
fail to map group of size 2 for tab size 512
[79/127] cmd.exe /c

But yasm build doesn't fail??

Is the issue related to python, e.g. python2 vs python3 ?

@madebr

madebr commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author
[78/127] Generating x86insn_gas.c
fail to map group of size 2 for tab size 512

Is the issue related to python, e.g. python2 vs python3 ?

I don't know but I don't think so. That error is emitted by C code (tools/genperf/perfect.c:565).
It's a warning/error about failing to create a perfect hashing function.
I looked a bit into running the unit tests using CMake, but upstream's lack of feedback is discouraging.

edit: definitely no. It was already happening before:
https://github.com/madebr/yasm/actions/runs/27537918380/job/81391982415#step:9:596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants