Skip to content

Fix PBES and OMAC flag scopes#687

Merged
sjaeckel merged 1 commit into
libtom:developfrom
UnknownDK:fix-flag-scopes
Apr 23, 2025
Merged

Fix PBES and OMAC flag scopes#687
sjaeckel merged 1 commit into
libtom:developfrom
UnknownDK:fix-flag-scopes

Conversation

@UnknownDK
Copy link
Copy Markdown
Contributor

pbes_properties and omac_state are gatekept by LTC_PBES and LTC_OMAC respectively. Therefore they should only be used within those scopes.

pbes_properties and omac_state are gatekept by LTC_PBES and LTC_OMAC
respectively. Therefore they should only be used within those scopes.
@UnknownDK
Copy link
Copy Markdown
Contributor Author

Fixes these errors with LTC_NOTHING.

 ~/r/libtomcrypt> make CFLAGS="-DLTC_NOTHING"                                                                                            2 develop
   * cc src/ciphers/aes/aes.o
In file included from src/ciphers/aes/aes.c:25:
./src/headers/tomcrypt_private.h:114:10: error: unknown type name ‘pbes_properties’
  114 |    const pbes_properties *data;
      |          ^~~~~~~~~~~~~~~
./src/headers/tomcrypt_private.h:182:19: error: unknown type name ‘omac_state’
  182 | int omac_vprocess(omac_state *omac, const unsigned char *in,  unsigned long inlen, va_list args);
      |                   ^~~~~~~~~~
make: *** [makefile:64: src/ciphers/aes/aes.o] Error 1

@UnknownDK
Copy link
Copy Markdown
Contributor Author

@sjaeckel is anything missing here?

@sjaeckel
Copy link
Copy Markdown
Member

Nope, sorry, I'll have a look later.

@sjaeckel sjaeckel merged commit 3905c28 into libtom:develop Apr 23, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants