Some improvements - #696
Merged
Merged
Conversation
sjaeckel
force-pushed
the
some-improvements
branch
5 times, most recently
from
September 5, 2025 14:04
4f72ecd to
3b16c88
Compare
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Allow using all hashes in case we didn't register our ciphers. Nobody should really use CHC, so we shouldn't make it mandatory. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
sjaeckel
force-pushed
the
some-improvements
branch
2 times, most recently
from
September 11, 2025 12:50
7b0d922 to
028775e
Compare
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
sjaeckel
force-pushed
the
some-improvements
branch
from
September 12, 2025 16:50
028775e to
6fe53a5
Compare
This will behave differently on 32bit architectures, but since 32bit is mostly dead and I don't see a way how to handle this w/o breaking ABI&API, I guess we have to live with it. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
sjaeckel
force-pushed
the
some-improvements
branch
from
September 13, 2025 10:22
6fe53a5 to
ae50082
Compare
MarekKnapek
pushed a commit
to MarekKnapek/libtomcrypt
that referenced
this pull request
Apr 13, 2026
Some improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of minor improvements and fixes.
The most important being the fixes of the
pk_oid_*APIs.This can also break stuff, since we're removing some more public DER helper APIs which shouldn't have been public in the first place (IMO).
Please check commit messages for details.