Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 58.33% 58.33%
=======================================
Files 1 1
Lines 48 48
Branches 14 14
=======================================
Hits 28 28
Misses 11 11
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
t/diag.t used Try::Tiny but it was never declared as a test prerequisite. On a freshly built perl that does not already have Try::Tiny installed (e.g. blead 5.45.1, as reported via IRC by @Tux), the toolchain does not pull it in, so t/diag.t dies at compile time ("Can't locate Try/Tiny.pm") and `make test` fails -- making the distribution appear not to install (GH#96). The two try{} blocks only swallowed exceptions around diagnostic Net::SSLeay version calls, so a plain eval { ...; 1 } or diag(...) is equivalent. This drops the dependency entirely instead of adding it to the prereqs, which keeps the test suite installable on minimal perls. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add a container-based job using perldocker/perl-tester:devel (which tracks the latest Perl development release) so we get an early signal when the dist breaks on the upcoming Perl -- exactly the class of problem behind GH#96, which the stable CI matrix (topping out at 5.42) never exercised. The job deliberately has no continue-on-error: a failure shows up as a red X so it is visible. Keep it OUT of the required status checks in branch protection so blead breakage never blocks a merge -- we want the signal, not a gate. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
oalders
marked this pull request as ready for review
July 23, 2026 00:34
I don't think it is. Previously it failed silently? Especially in the second case, for the vast majority of users on on OpenSSL the absence of a LibreSSL version number is entirely expected. Presenting a diag about that doesn't seem helpful. |
|
But I'm also wondering why it's using eval/try in the first place. Wouldn't it be easier to write something like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96
Problem
t/diag.tdiduse Try::Tiny qw( try );butTry::Tinywas never declared as a test prerequisite (not incpanfile,META.json, orMakefile.PL).On a freshly built perl that does not already have
Try::Tinyinstalled — e.g. blead 5.45.1, as reported via IRC by @Tux — the CPAN toolchain does not pull it in, sot/diag.tdies at compile time:make testthen fails, so the distribution appears not to install. The stable CI matrix tops out at 5.42 and thetest-jobinstalls only the declaredcpanfiledeps, so nothing currently catches this on the upcoming Perl.Changes
1. Remove the undeclared
Try::Tinydependency (t/diag.t)The two
try { ... }blocks only swallowed exceptions around diagnosticNet::SSLeayversion calls — nocatch. A plaineval { ...; 1 } or diag(...)is equivalent, so this drops the dependency entirely rather than adding it to the prereqs. Fewer test deps keeps the suite installable on minimal/blead perls, which is the whole point of the report. (Try::Tinywas the only undeclared test prereq — audited all oft/*.t.)2. Add a non-blocking blead CI job (
.github/workflows/dzil-build-and-test.yml)A container job on
perldocker/perl-tester:devel(tracks the latest Perl development release) that installs the declared deps and runs the suite. It has nocontinue-on-error, so a break shows up as a visible red X — but it is meant to be kept out of the required status checks in branch protection, so blead breakage never blocks a merge. This is the early-warning signal the stable matrix couldn't give for #96.Testing
Try::Tinyvia an@INChook:t/diag.t): exit 255,BEGIN failed--compilation aborted.t/diag.tpasses; theevalguard still catches theLIBRESSL_VERSION_NUMBERdie and continues.t/diag.tpasses withTry::Tinyboth present and absent.perltidyreports no changes;perl -cOK.t/https_proxy.t/t/example.tunchanged (need local sockets / internet unavailable in the dev sandbox; unaffected by this change).needs: build-job,develimage, nocontinue-on-error). The blead job itself will run for real on this PR.Notes
perl-reviewSTANDARDS preferTry::Tinyovereval; that preference is intentionally overridden here since the dependency itself is the cause of the install failure. Confirmed with the maintainer.perl-tester:develis a "fat" image with many modules preinstalled, so it reliably catches genuine blead code/test breakage but may not catch a future undeclared-prereq regression the way a truly minimal perl would. It's the reliable signal available given this repo's container-based CI; a strict minimal-prereq blead check would need a from-scratch perl build.