Unmute initially muted channels only if -S/--solo is provided.#73
Merged
sezero merged 1 commit intolibxmp:masterfrom Jan 28, 2026
Merged
Unmute initially muted channels only if -S/--solo is provided.#73sezero merged 1 commit intolibxmp:masterfrom
sezero merged 1 commit intolibxmp:masterfrom
Conversation
Fixes xmp-cli unmuting initially muted IT channels by default, causing incorrect sounds to play in various modules. Examples: channels 15-23 of Cyclone/almagest.it, channel 8 of Bombardment II (https://modarchive.org/index.php?request=view_by_moduleid&query=194589), and channel 4 of Zeux Champion (https://modarchive.org/index.php?request=view_by_moduleid&query=194586).
sezero
approved these changes
Jan 28, 2026
sezero
added a commit
to sezero/xmp-cli
that referenced
this pull request
Feb 24, 2026
so that we accommodate environments where char is unsigned by default. (Issue was introduced by libxmp#73)
AliceLR
pushed a commit
that referenced
this pull request
Feb 24, 2026
so that we accommodate environments where char is unsigned by default. (Issue was introduced by #73)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes xmp-cli unmuting initially muted IT channels by default, causing incorrect sounds to play in various modules.
Examples: channels 15-23 of Cyclone/almagest.it, channel 8 of Bombardment II, and channel 4 of Zeux Champion.
Fixes #71.