Implementing client.account.get_timeline()#144
Merged
kraktus merged 2 commits intolichess-org:masterfrom Dec 3, 2025
Merged
Conversation
JAMoreno-Larios
changed the title
kraktus
reviewed
Dec 2, 2025
kraktus
force-pushed
the
jaml_timeline
branch
from
2b44495 to
ed53aac
Compare
kraktus
added a commit
to kraktus/lila-db-seed
that referenced
this pull request
Dec 2, 2025
`playerId` has been replaced by `fullId` (I presume the breaking change was not intended) since 2022 lichess-org/lila@e8644d0#r171844996 found because it was breaking tests for lichess-org/berserk#144
kraktus
added a commit
to lichess-org/lila-db-seed
that referenced
this pull request
Dec 2, 2025
`playerId` has been replaced by `fullId` (I presume the breaking change was not intended) since 2022 lichess-org/lila@e8644d0#r171844996 found because it was breaking tests for lichess-org/berserk#144
kraktus
force-pushed
the
jaml_timeline
branch
2 times, most recently
from
f775111 to
53ba6b2
Compare
kraktus
force-pushed
the
jaml_timeline
branch
from
53ba6b2 to
2cd619c
Compare
Member
|
Thanks! This was significantly longer to review than I thought it would be! due to lichess-org/lila-db-seed#70 |
Contributor
Author
|
Great job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making a new PR for #129 and based on the discussion for #80, I added proper typing with TypedDict, added the corresponding tests.
Checklist when adding a new endpoint
README.mdclient.users.get_user(), Correct:client.users.get()berserk/types/, exampleCHANGELOG.mdin theTo be releasedsection (to be created if necessary)