Add missing API endpoints for puzzles, broadcasts, and users#157
Open
nkc-137 wants to merge 5 commits intolichess-org:masterfrom
Open
Add missing API endpoints for puzzles, broadcasts, and users#157nkc-137 wants to merge 5 commits intolichess-org:masterfrom
nkc-137 wants to merge 5 commits intolichess-org:masterfrom
Conversation
zaderrr
reviewed
Mar 21, 2026
zaderrr
left a comment
There was a problem hiding this comment.
Hi, I worked on a notes endpoint implementation, I didn't check the active PRs well enough and can see you've added the create note endpoint. Just added a comment as it's missing some data for the creation and not pointing to the correct endpoint
Comment on lines
+158
to
+164
| def create_note(self, username: str) -> None: | ||
| """Add a private note available only to you about this account. | ||
|
|
||
| :param username: The username of the user to create a note for | ||
| """ | ||
| path = f"/api/user/{username}/notification" | ||
| self._r.post(path) |
There was a problem hiding this comment.
This doesn't go to the note endpoint, also the note body isn't passed anywhere for the creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds new client methods and types for puzzle replay/race APIs, introduces a broadcast round reset endpoint, and adds the user note creation endpoint. Includes VCR cassettes/tests and updates README. This PR is to implement a few action items from #6.
Details
client.puzzles.get_puzzles_to_replayandclient.puzzles.get_racewith new TypedDicts for replay and race responses inberserk/types/.client.broadcasts.reset_roundand documented it in README.client.users.create_noteand documented it in README.Testing
make testChecklist when adding a new endpoint
README.mdclient.users.get_user(), Correct:client.users.get()berserk/types/, exampleCHANGELOG.mdin theTo be releasedsection (to be created if necessary)