Add bots.handle_draw_offers and bots.handle_takeback_offers#86
Merged
kraktus merged 4 commits intolichess-org:masterfrom Dec 3, 2025
Merged
Conversation
78 tasks
kraktus
force-pushed
the
add_bot_offers_endpoints
branch
from
d3fef51 to
469db70
Compare
…ck_offer``" in changelog
kraktus
force-pushed
the
add_bot_offers_endpoints
branch
from
a8d4817 to
6136e03
Compare
Member
|
Thanks! Sorry for the almost year-long review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist when adding a new endpoint
Added new endpoint to the
README.mdEnsured that my endpoint name does not repeat the name of the client. Wrong:
client.users.get_user(), Correct:client.users.get()Typed the returned JSON using TypedDicts in
berserk/types/, exampleI did not type the returned json since it is not typed in other bots endpoint methods. The response is quite minimal ({
"ok": true
}). I could add this (also for the other bot endpoints) if desirable.
Written tests for GET endpoints not requiring authentification. Documentation, example
These endpoints require authentication.
Added the endpoint and your name to
CHANGELOG.mdin theTo be releasedsection (to be created if necessary)