Fix insufficient material detection in Horde, add more test cases#51
Merged
veloce merged 5 commits intolichess-org:mainfrom Feb 19, 2026
Merged
Fix insufficient material detection in Horde, add more test cases#51veloce merged 5 commits intolichess-org:mainfrom
veloce merged 5 commits intolichess-org:mainfrom
Conversation
`setPieceAt` returns a new board but that was ignored here, leading to the pawn not being removed, causing infinite recursion add @useResult to make sure something like this does not happen again in the future.
Found this by comparing with scalachess
This is closer to what Scalachess does and makes the code more readable. _hordeBishops() now always returns the bishops of the Horde and _piecesBishops always returns the bishops of the pieces.
veloce
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.