fixed board animations when (remove animations) is on#86
Merged
veloce merged 1 commit intolichess-org:mainfrom Mar 10, 2026
Merged
Conversation
chess board animations are now working even when the "remove animations" accessibility setting is turned on in android system
Collaborator
|
I see the change. From your screen recording, the system behaviour is not even applied immediately (in the before video). I had to watch it several times to understand the difference. Now I am wondering, do we want this? I am not sure. Seems that the flutter default for animation is a sane default. Animations are not essential to the app, and why would we not disable them if the system is telling us to do so, in case the battery is low for instance? |
veloce
approved these changes
Mar 10, 2026
Collaborator
|
As discussed here, we actually want this: lichess-org/mobile#2534 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: lichess-org/mobile#2534
(this issue is in the main mobile project)
The change ensures that the animation behavior is the same even when (remove animations) setting is on in android accessibility settings.
Visual Changes
after.mp4
before.mp4