add validDropSquares to GameData to fix invalid drop moves in crazyhouse#90
Merged
veloce merged 1 commit intolichess-org:mainfrom Mar 11, 2026
Merged
add validDropSquares to GameData to fix invalid drop moves in crazyhouse#90veloce merged 1 commit intolichess-org:mainfrom
validDropSquares to GameData to fix invalid drop moves in crazyhouse#90veloce merged 1 commit intolichess-org:mainfrom
Conversation
Currently, the board considers any drop onto an open sqaure valid (excluding pawn drops onto the back rank). However, when in check this breaks down, leading to `onMove` being called for invalid drops, which is consistent with the behavior for normal moves (and causes crashes in lichess mobile currently). To fix this, introduce `GameData.validDropSquares`.
tom-anders
added a commit
to tom-anders/lichess-mobile
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the board considers any drop onto an open sqaure valid (excluding pawn drops onto the back rank).
However, when in check this breaks down, leading to
onMovebeing called for invalid drops, which is consistent with the behavior for normal moves (and causes crashes in lichess mobile currently).To fix this, introduce
GameData.validDropSquares.