Standardise checkbox/toggle UX on a few forms #19046
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkc-137
force-pushed
the
ux-checkbox-toggle-standardisation
branch
from
a2edc0c to
b04f32e
Compare
kraktus
reviewed
Jan 8, 2026
Comment on lines
87
to
111
| private def nativeCheckboxField( | ||
| field: Field, | ||
| labelContent: Frag, | ||
| help: Option[Frag], | ||
| half: Boolean, | ||
| value: String = "true" | ||
| ) = | ||
| div( | ||
| cls := List( | ||
| "form-check form-group" -> true, | ||
| "form-half" -> half | ||
| ) | ||
| )( | ||
| div( | ||
| span(cls := "form-check-input")( | ||
| form3.nativeCheckbox( | ||
| form3.id(field), | ||
| field.name, | ||
| checked = field.value.has("true"), | ||
| value = value | ||
| ) | ||
| ), | ||
| label(`for` := form3.id(field))(labelContent) | ||
| ), | ||
| help.map(small(cls := "form-help")(_)) |
Member
There was a problem hiding this comment.
you probably want to extract this as form3 helper to be able to use it for gameUI.scala for example
Author
There was a problem hiding this comment.
Got it! That makes sense, that would reduce code duplication. I will do that in the upcoming revision.
ornicar
reviewed
Jan 10, 2026
| help = frag("Include this round when calculating players' rating changes").some | ||
| "Rated round", | ||
| help = frag("Include this round when calculating players' rating changes").some, | ||
| half = true |
Collaborator
There was a problem hiding this comment.
half = true on purpose here?
ornicar
reviewed
Jan 10, 2026
| label(`for` := form3.id(field))(labelContent) | ||
| ), | ||
| help.map(small(cls := "form-help")(_)) | ||
| ) |
Collaborator
There was a problem hiding this comment.
hasn't that moved to Form3.scala?
ornicar
reviewed
Jan 10, 2026
| raw( | ||
| "Prevent reopening the account later. If you check this box, even administrators will be unable to reopen your account at your request." | ||
| ) | ||
| ) |
Collaborator
There was a problem hiding this comment.
couldn't this use nativeCheckboxField
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #17396
This PR standardises checkbox vs toggle switch UX on a subset of pages, following the guideline that instant apply settings should use toggle switches, while submit/save flows should use checkboxes.
Pages updated
Notes
Testing
sbt test