Skip to content

fix oauth authorization page for web:mod scope#20073

Merged
ornicar merged 1 commit intomasterfrom
oauth-modal-fix
Mar 22, 2026
Merged

fix oauth authorization page for web:mod scope#20073
ornicar merged 1 commit intomasterfrom
oauth-modal-fix

Conversation

@fitztrev
Copy link
Member

when an app requests web:mod scope, lila adds ok-cancel-confirm class which displays a modal before submitting. Clicking "ok" in the modal tries to click the form element that is no longer present in the DOM.

TypeError: Cannot read properties of null (reading 'remove')

when an app requests `web:mod` scope, lila adds `ok-cancel-confirm` class which displays a modal before submitting. Clicking "yes" in the modal tries to click the form element that is no longer present in the DOM.

```
TypeError: Cannot read properties of null (reading 'remove')
```
@ornicar ornicar merged commit 5a7dad6 into master Mar 22, 2026
18 checks passed
@fitztrev fitztrev deleted the oauth-modal-fix branch March 22, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants