Skip to content

Added hint button, need to add functionality.#1224

Closed
ItsDang wants to merge 4 commits intolichess-org:mainfrom
ItsDang:puzzle-show-hint
Closed

Added hint button, need to add functionality.#1224
ItsDang wants to merge 4 commits intolichess-org:mainfrom
ItsDang:puzzle-show-hint

Conversation

@ItsDang
Copy link
Copy Markdown
Contributor

@ItsDang ItsDang commented Dec 5, 2024

For #1158

@CloudyDino
Copy link
Copy Markdown
Contributor

CloudyDino commented Feb 16, 2025

Hey @ItsDang! Did you want any help closing this out? Looks like the things left are:

  • Using a green circle for the hint piece
  • Adding hintShown to PuzzleState and setting it to true if we're toggling the hint to show
  • Setting the puzzle solution's rated parameter to initialContext.userId != null && !state.hintShown
  • Checking if it's possible to preselect the piece the move is from instead of circling all those valid moves (Honestly, I'm not sure how to do this part)

@ItsDang
Copy link
Copy Markdown
Contributor Author

ItsDang commented Feb 17, 2025

Hey @CloudyDino, I'll try to get it fixed with the tests tomorrow, but feel free to work on it :) Thanks for adding the comment about the rated param 👍

@CloudyDino CloudyDino mentioned this pull request Feb 17, 2025
@ItsDang ItsDang closed this Feb 18, 2025
@ItsDang ItsDang reopened this Feb 18, 2025
@ItsDang
Copy link
Copy Markdown
Contributor Author

ItsDang commented Feb 18, 2025

Reopened to check if my changes would pass the tests, mainly to check if the save formatting passed, the dart format command from contribution isn't working for me? Going to close, please merge @CloudyDino's #1459 instead 😄.

@ItsDang ItsDang closed this Feb 18, 2025
@ItsDang ItsDang deleted the puzzle-show-hint branch February 27, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants