Skip to content

feat: show chapter numbers#1438

Merged
veloce merged 2 commits intolichess-org:mainfrom
vincendep:feat/study-chapter-numbers
Feb 14, 2025
Merged

feat: show chapter numbers#1438
veloce merged 2 commits intolichess-org:mainfrom
vincendep:feat/study-chapter-numbers

Conversation

@vincendep
Copy link
Copy Markdown
Contributor

closes #1392

@veloce veloce merged commit e447b95 into lichess-org:main Feb 14, 2025
@veloce
Copy link
Copy Markdown
Contributor

veloce commented Feb 14, 2025

Thanks!

@vincendep vincendep deleted the feat/study-chapter-numbers branch February 14, 2025 17:20
@ijm8710
Copy link
Copy Markdown

ijm8710 commented Feb 18, 2025

@vincendep wouls you agree the mobile web styling for numbers looks better than plaintext (bolder and blue)? image

image

@vincendep
Copy link
Copy Markdown
Contributor Author

Hi @ijm8710, yes I agree with you. Should the issue be reopened so I can make another pull request?

@ijm8710
Copy link
Copy Markdown

ijm8710 commented Feb 18, 2025

Hmm idk on that one or if can just prepare a quick PR update and see if Veloce is good to accept?

@ijm8710
Copy link
Copy Markdown

ijm8710 commented Feb 25, 2025

@tom-anders since you're the study guy you think it's cool to reopen this and for him to tweak that?

@tom-anders
Copy link
Copy Markdown
Collaborator

Sure, but I guess it would also be fine to just open a new PR without reopening the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Study: add numbers to chapter overview

4 participants