fix: register socket listeners before awaiting first connection#2762
Merged
veloce merged 1 commit intolichess-org:mainfrom Mar 16, 2026
Merged
Conversation
Move connectedStream and stream listener registration before `await _socketClient.firstConnection` in broadcast and TV controllers to avoid missing reconnection events during the initial connection. Similar pattern to the race condition fixed in RetroController (lichess-org#2756).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While investigating #2750 (fixed in #2756), we found the same race condition pattern in three other places: socket event listeners registered after
await _socketClient.firstConnection, meaning reconnection events firing during the initial connection gap could be missed.Affected controllers:
BroadcastRoundController—connectedStream.listen()moved beforeawait firstConnectionBroadcastAnalysisController— same patternLiveTvChannels— bothconnectedStream.listen()andstream.listen()moved beforeawait firstConnectionThe fix is the same in all cases: register listeners before awaiting, so no events are lost.
Test plan