fix: add request timeout to prevent indefinite loading#2777
Merged
veloce merged 1 commit intolichess-org:mainfrom Mar 16, 2026
Merged
fix: add request timeout to prevent indefinite loading#2777veloce merged 1 commit intolichess-org:mainfrom
veloce merged 1 commit intolichess-org:mainfrom
Conversation
Adds a default request timeout in LichessClient.send() to prevent requests from hanging indefinitely, which can cause screens to stay stuck in loading state (e.g. friends screen). Fixes lichess-org#2724
Contributor
|
I merged it because it is good to have a global timeout. But I don't think it fixes the loading issue in friends screen. As I understand the issue the server returns data, so we may have another problem in the app. |
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LichessClient.send()The timeout is applied at the
LichessClientlayer, so it covers all API requests without needing per-call configuration. The timeout is astatic constthat can be referenced if specific calls need to document why they override it.Test plan
EDIT: (maintainer)
I removed the issue marked as fixed.