Cancel any pending lobby seek when accepting a challenge#2795
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #2638 by ensuring an active lobby matchmaking seek is cancelled before accepting a challenge, preventing the app from being matched into a second game mid-play.
Changes:
- Cancel any pending lobby seek before accepting a challenge from the challenge requests screen.
- Cancel any pending lobby seek before accepting a challenge from the in-app challenge confirmation flow (ChallengeService).
- Refactor
CreateGameServiceto take a preloadedsriand makecancelSeek()a no-op when no lobby seek is active.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
lib/src/view/user/challenge_requests_screen.dart |
Cancels any active lobby seek before accepting a challenge from the list UI. |
lib/src/model/lobby/create_game_service.dart |
Passes/stores sri in the service and adjusts seek creation/cancellation behavior. |
lib/src/model/challenge/challenge_service.dart |
Cancels any active lobby seek before accepting challenges from notification/confirm-dialog flows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| // while accepting a challenge. | ||
| try { | ||
| await ref.read(createGameServiceProvider).cancelSeek(); | ||
| } catch (_) {} |
| // while accepting a challenge. | ||
| try { | ||
| await ref.read(createGameServiceProvider).cancelSeek(); | ||
| } catch (_) {} |
Comment on lines
172
to
179
| Future<void> _acceptChallenge(ChallengeId id) async { | ||
| // Cancel any pending lobby seek before accepting, to prevent being matched into a new game | ||
| // while accepting a challenge. | ||
| try { | ||
| await ref.read(createGameServiceProvider).cancelSeek(); | ||
| } catch (_) {} | ||
|
|
||
| final fullId = await acceptChallenge(id); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2638