Fix retro reuse existing analysis#2859
Open
sviluppatoredisoftware wants to merge 2 commits intolichess-org:mainfrom
Open
Fix retro reuse existing analysis#2859sviluppatoredisoftware wants to merge 2 commits intolichess-org:mainfrom
sviluppatoredisoftware wants to merge 2 commits intolichess-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2564 and #2750
What this changes
This PR tries to fix the case where Learn from your mistakes can get stuck / keep loading after a computer analysis was already requested first.
The issue seems to come from the retro flow attaching too late to analysis progress and potentially trying to request / restart analysis again for the same game.
Changes
400 already requestedWhy
This should help with the cases described in:
Learn from your misstake "something went wrong""Learn from your mistakes" sometimes remains stuck loading