Skip to content

Fix: save all PGN header fields before exporting #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaartenD wants to merge 5 commits into
base: main
Choose a base branch
from
+13 −1
Open

Fix: save all PGN header fields before exporting #2864

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c87546
Fix: save all PGN header fields before exporting
MaartenD Mar 29, 2026
281c794
chore: add devtools.yaml to gitignore
MaartenD Mar 30, 2026
98dfa03
Fix: save all PGN header fields before exporting
MaartenD Mar 31, 2026
1a3ea81
Fix: save all PGN header fields before exporting
MaartenD Mar 31, 2026
6a9464c
Fix: Added null check removed non-null assertion operator
MaartenD Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/src/view/analysis/analysis_share_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ class _EditPgnTagsFormState extends ConsumerState<_EditPgnTagsForm> {
_focusNodes[entry.key] = FocusNode();
_focusNodes[entry.key]!.addListener(() {
if (!_focusNodes[entry.key]!.hasFocus) {
ref.read(ctrlProvider.notifier).updatePgnHeader(entry.key, _controllers[entry.key]!.text);
final controller = _controllers[entry.key];
if (controller != null) {
ref.read(ctrlProvider.notifier).updatePgnHeader(entry.key, controller.text);
}
}
});
}
Expand Down Expand Up @@ -162,6 +165,15 @@ class _EditPgnTagsFormState extends ConsumerState<_EditPgnTagsForm> {
builder: (context) {
return FilledButton(
onPressed: () {
for (final entry in pgnHeaders.entries) {
final controller = _controllers[entry.key];
if (controller == null) {
throw StateError('Controller missing for key: ${entry.key}');
}
ref
.read(ctrlProvider.notifier)
.updatePgnHeader(entry.key, controller.text);
}
launchShareDialog(
context,
ShareParams(
Expand Down