addQueryParams filter missing keys

.github/workflows/ci.yml

@@ -2,33 +2,26 @@ name: Continuous Integration
 
 on:
   pull_request:
-    branches: ['**']
   push:
-    branches: ['**']
 
 jobs:
   openjdk21:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        java-version: [21, 25]
     steps:
+      - uses: actions/checkout@v6
 
-      - name: Checkout current branch
-        uses: actions/checkout@v4
-
-      - name: Setup sbt
-        uses: sbt/setup-sbt@v1
-
-      - name: Setup JVM
-        uses: actions/setup-java@v4
+      - uses: actions/setup-java@v5
         with:
           distribution: temurin
-          java-version: 21
+          java-version: ${{ matrix.java-version }}
           cache: sbt
 
-      - name: Build project
-        run: sbt compile
-
-      - name: Test project
-        run: sbt test
+      - name: Setup sbt
+        uses: sbt/setup-sbt@v1
 
-      - name: Check Formatting
-        run: sbt scalafmtCheckAll
+      - run: sbt compile
+      - run: sbt test
+      - run: sbt scalafmtCheckAll

lila/src/main/scala/StringOps.scala

@@ -44,6 +44,7 @@ object StringOps:
       val mergedParams = existingParams ++ params.map { (k, v) => k -> Some(urlencode(v)) }
 
       val queryString = mergedParams // we could encode the key, and we should, but is it really necessary?
+        .filter((key, _) => key.nonEmpty)
         .map: (key, value) =>
           value.fold(key)(v => s"$key=$v")
         .mkString("&")

lila/src/test/scala/StringOpsTest.scala

@@ -140,5 +140,5 @@ line"""),
     )
     assertEquals(
       addQueryParams("https://example.com/path?=value1&key2=&=&&key3=value3", Map("key1" -> "value1")),
-      "https://example.com/path?&key2=&key3=value3&key1=value1"
+      "https://example.com/path?key2=&key3=value3&key1=value1"
     )