Visualize brake and indicator lights#115
Merged
rmessaou merged 4 commits intoAug 5, 2025
Merged
Conversation
buraktiryaki
force-pushed
the
feat/visualize-brake-and-indicator-lights
branch
from
2153d71 to
2f6c6d1
Compare
buraktiryaki
force-pushed
the
feat/visualize-brake-and-indicator-lights
branch
from
2f6c6d1 to
f3fbf85
Compare
rmessaou
reviewed
Aug 4, 2025
Collaborator
|
Please add a test .mcap file to showcase the feature |
rmessaou
approved these changes
Aug 5, 2025
jdsika
requested changes
Aug 5, 2025
jdsika
left a comment
jdsika
left a comment
Collaborator
There was a problem hiding this comment.
- Cubes should not be outside of the vehicle bounding box
- Placement shall work for differently sized vehicles
- Please add proper exception handling for corrupt/missing data input
- Are placement constants derived from specifications/norms?
Collaborator
|
Also check the behavior with motorcycles and scooters etc which can also be meant if it has a "vehicleClassification" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for visualizing brake and indicator lights:
mcap for testing: https://github.com/lichtblick-suite/asam-osi-converter/pull/115/files#diff-5f6e2359b47f40b7d494cb4e4ff8ddbf8bbda37c01faf481377cec177edb6fdb