Visualize brake and indicator lights - Follow Up

[buraktiryaki]

The lights are now correctly positioned within the bounding box.

Also mounting position of the lights correct for the vehicle with different size:

[thomassedlmayer]

@buraktiryaki @jdsika Are you aware that this change breaks the rendering of frames that contain moving objects that do not have (brake) lights? Nothing is being rendered in that case, since the extension just exits on a type error.

This should be checked again. Pedestrians or animals usually don't have lights at all and in my opinion it should also be allowed to have incomplete OSI data (vehicles without light definitions) and still be able to render the rest of the object.

[jdsika]

@buraktiryaki @jdsika Are you aware that this change breaks the rendering of frames that contain moving objects that do not have (brake) lights? Nothing is being rendered in that case, since the extension just exits on a type error.

This should be checked again. Pedestrians or animals usually don't have lights at all and in my opinion it should also be allowed to have incomplete OSI data (vehicles without light definitions) and still be able to render the rest of the object.

I did explicitly ask to check this and I guess it will be fixed in the next PR

[jdsika]

@thomassedlmayer would you mind providing your .mcap file that produces the crash? (you could add it to the data folder)

[thomassedlmayer]

@jdsika I added an example file with very minimal OSI content (no lights etc.) which IMO should be able to be visualized by the viewer. The file can also be used to check that moving objects actually disappear in the viewer once they are omitted in an OSI message.

Btw it does not crash the whole application, the error just gets caught by the "try" statement and the rest of the rendering process is skipped for each frame.