fix(ui): consolidate shimmer gradients, prune decorative, use paper tokens - #188
Conversation
…e paper tokens --skeleton-shimmer token added to :root with the shared 90deg 3-stop pattern. Six inline shimmers replaced with var(--skeleton-shimmer) in node-workspace, right-panel, sidebar-history, and progress-composer. .settings-workspace: removed decorative radial+linear gradients that impair form control contrast at D5 density; replaced with var(--bg). .canvas__blank-sheet in right-panel.css: removed dead background declaration (viewer-workflow.css wins by source order); structural properties (dimensions, border, box-shadow) preserved. viewer-workflow.css: #ffffff/#f8fafc replaced with var(--paper)/ var(--paper-edge) tokens defined by wp4. Gradient count: 48 → 40 (functional 18, state 6, scrim 2, decorative 14).
5 assertions: exhaustive 40-entry manifest (functional 18 / state 6 / scrim 2 / decorative 14), category totals, --skeleton-shimmer 1 def + 6 refs, .canvas__blank-sheet background in one file only, per-file decorative cap at 3.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2891a87ead
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,132 @@ | |||
| import { describe, it } from "node:test"; | |||
There was a problem hiding this comment.
Adding this test changes the input enumerated by scripts/classify-tests.mjs, but the generated docs/migration/runtime-test-inventory.md was not updated. Running the required npm run test:inventory check now exits with docs/migration/runtime-test-inventory.md is stale, so verify:release:source stops before the UI build and test suite on every release attempt. Regenerate and commit the inventory alongside this test.
AGENTS.md reference: AGENTS.md:L89-L95
Useful? React with 👍 / 👎.
F1: Pin shimmer consumer files explicitly (4 files, 6 refs). F2: Live browser probe confirms .settings-workspace renders bgColor=rgb(11,11,15) (var(--bg)), bgImage=none — no gradients. F3: blank-sheet check broadened to catch background-image.
Original sections claimed per-declaration exhaustive manifest but implementation uses file-level counting. Rewritten to honestly describe the file-level approach and defer settings render to wp7.
1 participant
Summary
Gradient count reduced from 48 to 40 through shimmer consolidation,
decorative pruning, and paper token migration.
Shimmer consolidation (state 11 → 6)
New
--skeleton-shimmertoken in:rootwith the shared 90deg 3-stoppattern. Six inline shimmers replaced with
var(--skeleton-shimmer)innode-workspace, right-panel, sidebar-history, progress-composer.
Decorative pruning (17 → 14)
control contrast at D5 density; replaced with
var(--bg)declaration (viewer-workflow.css wins by source order)
Paper token migration
viewer-workflow.css:
#ffffff/#f8fafc→var(--paper)/var(--paper-edge)Final counts
Tests