Skip to content

Conversation

@madlabman
Copy link
Contributor

@madlabman madlabman commented Dec 11, 2025

Description

Implement IStakingModuleV2 interface for CSM.

Checklist

  • Appropriate PR labels applied
  • Test coverage maintained (just coverage)
    • Tests are added/updated
  • Documentation maintained
    • No need to update

@madlabman madlabman added the WIP label Dec 11, 2025
@madlabman madlabman force-pushed the istaking-module-v2-csm branch 4 times, most recently from e2bdbe3 to ad030ef Compare December 11, 2025 18:03
@madlabman madlabman force-pushed the istaking-module-v2-csm branch 13 times, most recently from b0ef630 to 724e76a Compare December 18, 2025 08:43
@madlabman madlabman added CSM v3 and removed WIP labels Dec 18, 2025
@madlabman madlabman force-pushed the istaking-module-v2-csm branch from 724e76a to 3f4fe0b Compare December 18, 2025 09:22
@madlabman madlabman changed the title wip: IStakingModuleV2 in CSM feat: IStakingModuleV2 in CSM Dec 18, 2025
@madlabman madlabman marked this pull request as ready for review December 18, 2025 09:33
@madlabman madlabman requested review from a team as code owners December 18, 2025 09:33
@madlabman madlabman force-pushed the istaking-module-v2-csm branch from 3f4fe0b to 2f79e7b Compare December 18, 2025 11:13
@madlabman madlabman force-pushed the istaking-module-v2-csm branch from 2f79e7b to a95c8d0 Compare December 18, 2025 13:01
Copy link
Contributor

@dgusakov dgusakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at tests for now

@madlabman madlabman force-pushed the istaking-module-v2-csm branch from f49ea64 to 671c9a8 Compare January 12, 2026 10:36
}

// NOTE: Zeroing out the storage slot, since it's unreachable after `dequeue`.
self.items[self.head] = TopUpQueueItem.wrap(0x00);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a circular buffer with size 256

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to implement one here. So far I didn't like it much, so I suggest to return to it later.

@madlabman madlabman force-pushed the istaking-module-v2-csm branch from f28b8f8 to fa53611 Compare January 15, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants