-
Notifications
You must be signed in to change notification settings - Fork 19
feat: IStakingModuleV2 in CSM #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
e2bdbe3 to
ad030ef
Compare
b0ef630 to
724e76a
Compare
724e76a to
3f4fe0b
Compare
3f4fe0b to
2f79e7b
Compare
2f79e7b to
a95c8d0
Compare
dgusakov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked at tests for now
f49ea64 to
671c9a8
Compare
| } | ||
|
|
||
| // NOTE: Zeroing out the storage slot, since it's unreachable after `dequeue`. | ||
| self.items[self.head] = TopUpQueueItem.wrap(0x00); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a circular buffer with size 256
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to implement one here. So far I didn't like it much, so I suggest to return to it later.
f28b8f8 to
fa53611
Compare
Description
Implement
IStakingModuleV2interface for CSM.Checklist
just coverage)