feat: track only a pending batches in the consolidation bus#1692
Open
mkurayan wants to merge 1 commit intofeat/staking-router-3.0from
Open
feat: track only a pending batches in the consolidation bus#1692mkurayan wants to merge 1 commit intofeat/staking-router-3.0from
mkurayan wants to merge 1 commit intofeat/staking-router-3.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, batch hashes are stored to prevent duplicate submissions. If the same batch is submitted again, the transaction reverts because the hash already exists.
However, this approach is flawed.
Consider a batch containing a single request. If the request fails (e.g., the validator has not yet become active), it is rejected on the CL. Although
ConsolidationMigratorverifies that a deposit was made, this does not guarantee the validator is already active.If the same batch is then resubmitted, it fails immediately because its hash is already stored, making retry impossible even though the original request never succeeded.