fix: cb + dao steps pinned - #1919
Open
AlexandrMov wants to merge 1 commit into
Open
Conversation
|
Hardhat Unit Tests Coverage SummaryDetailsDiff against masterResults for commit: 5aee58e Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates deployment automation to ensure scratch/DAO migrations run with an explicitly pinned steps list and adjusts Foundry broadcast gas configuration for the CircuitBreaker deploy step.
Changes:
- Update CircuitBreaker deploy step to use a high
--gas-estimate-multiplierand document why--gas-limitis not sufficient for the broadcast tx. - Export
STEPS_FILE=scratch/steps.jsonindao-deploy.shto prevent migrations from failing when running in external-node / forking mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/scratch/steps/0100-deploy-circuit-breaker.ts | Switches broadcast gas control to --gas-estimate-multiplier and adds detailed rationale for Foundry behavior under Amsterdam gas accounting. |
| scripts/dao-deploy.sh | Pins STEPS_FILE to the full scratch steps list to avoid missing-env failures in the forking/external-node deploy path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short summary of the changes.
Context
What the reviewer needs to know
Problem
What problem this PR solves, link relevant issue if it exists
Solution
Your proposed solution