Omnibus 20.01.2026 (#198 - Lido V3 Phase 2, CSM Share → 7.5%, Grant role to CSM Performance Oracle report weekday offset contract) #580
+1,854
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgusakov
reviewed
Jan 9, 2026
iamnp
requested changes
Jan 11, 2026
Contributor
iamnp
left a comment
iamnp
left a comment
There was a problem hiding this comment.
looks solid ❤️
please address the comments
iamnp
changed the title
iamnp
reviewed
Jan 13, 2026
| UPDATE_VAULTS_FEES_IN_OPERATOR_GRID_FACTORY = "0x5C3bDFa3E7f312d8cf72F56F2b797b026f6B471c" # TODO update address after deployment | ||
|
|
||
| # Test parameters | ||
| EXPECTED_VOTE_ID = None # Set to None to create a new vote each test run |
Contributor
There was a problem hiding this comment.
Suggested change
| EXPECTED_VOTE_ID = None # Set to None to create a new vote each test run | |
| EXPECTED_VOTE_ID = 198 |
iamnp
reviewed
Jan 13, 2026
iamnp
reviewed
Jan 13, 2026
iamnp
reviewed
Jan 13, 2026
TheDZhon
reviewed
Jan 14, 2026
tests/test_2026_01_20.py
Outdated
| # ==================== After DG proposal executed checks ================== | ||
| # ========================================================================= | ||
|
|
||
| # TODO Step 1.1. Check old VaultsAdapter does not have REGISTRY_ROLE on OperatorGrid |
feat: Lido V3 CI tests
There was a problem hiding this comment.
Pull request overview
This pull request implements the Lido V3 Phase 2 voting script and comprehensive test suite. The PR contains three main components:
Purpose: Activate Lido V3 Phase 2 (Full Launch), increase Community Staking Module share limit to 7.5%, and grant permissions for CSM Performance Oracle weekday offset functionality.
Changes:
- Submit a Dual Governance proposal with 15 sub-items including role migrations, proxy upgrades, parameter updates, and permission grants
- Replace 7 Easy Track factories for Lido V3 vault management (old Phase 1 → new Phase 2)
- Comprehensive test coverage with over 1,350 lines of test code including scenario tests and permission checks
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
utils/test/rpc_helpers.py |
New utility function for setting storage slots during testing, supporting multiple RPC methods (Hardhat, Anvil, Geth) |
tests/test_2026_01_20.py |
Comprehensive test suite with voting execution, DG proposal execution, Easy Track factory migrations, and scenario tests |
scripts/upgrade_2026_01_20_v3_phase_2.py |
Voting script implementing the proposal with 15 vote items |
tests/snapshot/test_lido_snapshot.py |
Updated snapshot tests to account for max external ratio change (3% → 30%) |
tests/regression/test_permissions.py |
Updated permission expectations for TwoPhaseFrameConfigUpdate contract |
tests/regression/test_gate_seal.py |
Removed temporary PDG unpause code (now handled by the vote) |
configs/config_mainnet.py |
Updated CSM parameters and VaultsAdapter address |
interfaces/TwoPhaseFrameConfigUpdate.json |
New interface definition for the TwoPhaseFrameConfigUpdate contract |
.github/workflows/*.yml |
CI workflow configuration updates (runner and branch changes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test: fix snap test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lido V3 phase 2 voting script.