Skip to content

fix(Stonks): split stonks test into 2 parts - #670

Merged
iamnp merged 7 commits into
feat/next-votefrom
fix/stonks-test
Aug 4, 2026
Merged

fix(Stonks): split stonks test into 2 parts#670
iamnp merged 7 commits into
feat/next-votefrom
fix/stonks-test

Conversation

@phonktown

Copy link
Copy Markdown
Contributor

No description provided.

@phonktown
phonktown requested a review from a team as a code owner August 3, 2026 15:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the vote/stonks testing and CI flows to handle fork time warps caused by vote enactment, while updating associated on-chain metadata and interfaces for the 2026-08-05 upgrade/test suite.

Changes:

  • Split stonks integration CI into “pre-vote” and “post-vote” passes, with a fork restart between them.
  • Add a CI utility to refresh the vaults report after vote enactment so core tests don’t fail on VaultReportStale.
  • Update 2026-08-05 upgrade metadata/IPFS description inputs, tighten role-holder assertions in the test, and align the TokenRateNotifierV2 ABI + test call sites.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_2026_08_05.py Updates IPFS CID assertion and adds stricter role-member-count checks; adjusts notifier observer access to match ABI.
scripts/upgrade_2026_08_05.py Refreshes DG proposal metadata and IPFS description text used for vote creation.
scripts/ci/refresh_vaults_report.py New CI helper script to submit an oracle report when the vaults report is stale after time warp.
Makefile Adds split stonks integration targets and a target to refresh the vaults report in CI.
interfaces/TokenRateNotifierV2.json Updates ABI to match notifier v2 (observer tuple shape, events, ownership helpers).
.github/workflows/stonks_integration_tests.yml Runs stonks integration tests in two phases with a fork restart.
.github/workflows/core_tests.yml Adds a step to refresh the vaults report before running core tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile Outdated
Comment thread .github/workflows/core_tests.yml
@iamnp
iamnp merged commit c2ed5e8 into feat/next-vote Aug 4, 2026
2 of 4 checks passed
@iamnp
iamnp deleted the fix/stonks-test branch August 4, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants