fix(Stonks): split stonks test into 2 parts - #670
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the vote/stonks testing and CI flows to handle fork time warps caused by vote enactment, while updating associated on-chain metadata and interfaces for the 2026-08-05 upgrade/test suite.
Changes:
- Split stonks integration CI into “pre-vote” and “post-vote” passes, with a fork restart between them.
- Add a CI utility to refresh the vaults report after vote enactment so core tests don’t fail on
VaultReportStale. - Update 2026-08-05 upgrade metadata/IPFS description inputs, tighten role-holder assertions in the test, and align the TokenRateNotifierV2 ABI + test call sites.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_2026_08_05.py |
Updates IPFS CID assertion and adds stricter role-member-count checks; adjusts notifier observer access to match ABI. |
scripts/upgrade_2026_08_05.py |
Refreshes DG proposal metadata and IPFS description text used for vote creation. |
scripts/ci/refresh_vaults_report.py |
New CI helper script to submit an oracle report when the vaults report is stale after time warp. |
Makefile |
Adds split stonks integration targets and a target to refresh the vaults report in CI. |
interfaces/TokenRateNotifierV2.json |
Updates ABI to match notifier v2 (observer tuple shape, events, ownership helpers). |
.github/workflows/stonks_integration_tests.yml |
Runs stonks integration tests in two phases with a fork restart. |
.github/workflows/core_tests.yml |
Adds a step to refresh the vaults report before running core tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iamnp
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.