Skip to content

Union modals standart for forms#34

Merged
ev-d merged 10 commits intodevelopfrom
feature/si-1879-union-modals-standart-for-forms
Apr 25, 2025
Merged

Union modals standart for forms#34
ev-d merged 10 commits intodevelopfrom
feature/si-1879-union-modals-standart-for-forms

Conversation

@ev-d
Copy link
Copy Markdown
Contributor

@ev-d ev-d commented Apr 24, 2025 •
edited
Loading

Description

  • Update pagination for all vaults screen
  • Update claim modal
  • Update fund modal
  • Update withdrawal modal
  • Update mint modal
  • Update repay modal

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@ev-d ev-d marked this pull request as ready for review April 25, 2025 01:21
@ev-d ev-d requested a review from a team as a code owner April 25, 2025 01:21
@preview-stands
Copy link
Copy Markdown

preview-stands bot commented Apr 25, 2025 •
edited
Loading

Preview stand status

Stand was demolished

Jeday
Jeday requested changes Apr 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jeday Jeday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very DRY, spend a few minutes more to create common solution and you will find that:

  • it takes as long as copy pasting
  • saves tremendous amount of time even in tight deadlines

Comment thread features/adjustment/mint/form/feature-tx-info/feature-tx-info.tsx Outdated
Comment thread features/adjustment/mint/form/feature-tx-info/feature-tx-info.tsx Outdated
Comment thread features/adjustment/repay/form/feature-tx-info/feature-tx-info.tsx Outdated
Comment thread features/claim/claim-form/form/feature-tx-info/feature-tx-info.tsx Outdated
Comment thread features/claim/claim-form/hooks/use-claim-with-delegation.ts
Comment thread features/claim/claim-form/submit-modal/submit-modal.tsx Outdated
Comment thread features/overview/contexts/vault-overview.tsx Outdated
Comment thread features/supply/fund/form/feature-tx-info/feature-tx-info.tsx
Jeday
Jeday reviewed Apr 25, 2025
View reviewed changes
Comment thread shared/components/submit-modal/submit-modal.tsx Outdated
Jeday
Jeday previously approved these changes Apr 25, 2025
View reviewed changes
@ev-d ev-d merged commit 3149dc9 into develop Apr 25, 2025
3 of 4 checks passed
@ev-d ev-d deleted the feature/si-1879-union-modals-standart-for-forms branch April 25, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiRaiks DiRaiks DiRaiks left review comments

@Jeday Jeday Jeday approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ev-d @Jeday @DiRaiks