Skip to content

feat: update overview data, fix pagination, fix switcher#35

Merged
Jeday merged 5 commits intodevelopfrom
fix/components
Apr 25, 2025
Merged

feat: update overview data, fix pagination, fix switcher#35
Jeday merged 5 commits intodevelopfrom
fix/components

Conversation

@DiRaiks
Copy link
Copy Markdown
Contributor

@DiRaiks DiRaiks commented Apr 24, 2025

Description

ABI and Function Updates:

  • Updated VaultViewerAbi in abi/vault-viewer.ts to improve readability by reformatting input and output definitions. Additionally, renamed VaultDataViewer.VaultState to VaultViewer.VaultState for consistency. [1] [2]
  • Adjusted the structure of several functions such as vaultsByOwner, vaultsByOwnerBound, and vaultsConnectedBound to use expanded formatting for inputs and outputs. [1] [2]

Adjustment Tabs Refactor:

  • Replaced ToggleSwitch with Switch in adjustment-tabs.tsx and updated routing logic to use predefined routes instead of dynamic callbacks.
  • Capitalized labels in adjustmentToggleList for better UI consistency.

Mint Functionality Refactor:

  • Consolidated mint-related hooks by replacing useSimulationMintWithDelegation and useMintWithDelegation with useSimulationMint and useMint, simplifying the naming and usage. [1] [2] [3] [4] [5] [6]

Vault Overview Enhancements:

  • Replaced mintedEth with liabilityStETH in vault-overview.tsx to align with updated terminology.
  • Integrated a new utility function, calculateOverview, to centralize and simplify calculations for vault metrics such as utilization ratio and total minting capacity. [1] [2]

Miscellaneous Improvements:

  • Added active page tracking in pagination for AllVaults and ensured the loader displays correctly during data fetching. [1] [2]
  • Updated key names in capacity.tsx and health.tsx to reflect the new liabilityStETH terminology. [1] [2]

Demo

Code review notes

Testing notes

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@DiRaiks DiRaiks requested a review from a team as a code owner April 24, 2025 23:40
@preview-stands
Copy link
Copy Markdown

preview-stands bot commented Apr 24, 2025

Preview stand status

Stand was demolished

Jeday
Jeday previously approved these changes Apr 25, 2025
Comment thread features/adjustment/adjustment-tabs.tsx
Comment thread features/adjustment/mint/hooks/use-mint-with-delegation.ts
Comment thread features/overview/contexts/vault-overview.tsx Outdated
Comment thread features/supply/fund/hooks/use-fund-with-dashboard.ts
@Jeday Jeday merged commit 7a49c81 into develop Apr 25, 2025
4 of 5 checks passed
@Jeday Jeday deleted the fix/components branch April 25, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants