feat: update overview data, fix pagination, fix switcher#35
Merged
Conversation
Preview stand statusStand was demolished |
Jeday
previously approved these changes
Apr 25, 2025
Jeday
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ABI and Function Updates:
VaultViewerAbiinabi/vault-viewer.tsto improve readability by reformatting input and output definitions. Additionally, renamedVaultDataViewer.VaultStatetoVaultViewer.VaultStatefor consistency. [1] [2]vaultsByOwner,vaultsByOwnerBound, andvaultsConnectedBoundto use expanded formatting for inputs and outputs. [1] [2]Adjustment Tabs Refactor:
ToggleSwitchwithSwitchinadjustment-tabs.tsxand updated routing logic to use predefined routes instead of dynamic callbacks.adjustmentToggleListfor better UI consistency.Mint Functionality Refactor:
useSimulationMintWithDelegationanduseMintWithDelegationwithuseSimulationMintanduseMint, simplifying the naming and usage. [1] [2] [3] [4] [5] [6]Vault Overview Enhancements:
mintedEthwithliabilityStETHinvault-overview.tsxto align with updated terminology.calculateOverview, to centralize and simplify calculations for vault metrics such as utilization ratio and total minting capacity. [1] [2]Miscellaneous Improvements:
AllVaultsand ensured the loader displays correctly during data fetching. [1] [2]capacity.tsxandhealth.tsxto reflect the newliabilityStETHterminology. [1] [2]Demo
Code review notes
Testing notes
Checklist: