feat: update overview, pagination, tables, data#37
Merged
Conversation
Preview stand statusStand was demolished |
Jeday
previously approved these changes
Apr 25, 2025
Jeday
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Functional Enhancements:
useVaultDataTablehook to fetch and process vault data, replacing the olderuseVaultDatahook across various components. This includes calculating health scores and fetching additional vault details. [1] [2] [3]useVaultsDataAllanduseVaultsDataByOwnerhooks to use the newuseVaultDataTable, improving data handling and adding avaultsCountproperty for pagination. [1] [2] [3]VAULTS_PER_PAGEconstant to increase the number of vaults displayed per page from 4 to 6.Vault Table Updates:
VaultTablecomponent to include thevaultsCountprop for accurate title counters and updated column headers to reflect new terminology like "Total value, ETH" and "Health factor." [1] [2]Styling Improvements:
TableTitlestyling to dynamically adjust background colors based on theme (dark/light mode) and added amin-widthproperty for better alignment. [1] [2]MyVaultsWrapperstyled component for consistent layout in the "My Vaults" section.Data Formatting Adjustments:
EtherCellcomponent and enabled trimming ellipsis for better readability.PercentCelland other contexts to divide values by 100 for proper representation. [1] [2]Dependency Updates:
@lidofinance/lsv-clidependency to version1.0.0-alpha.36for compatibility with the new health score calculations.Demo
Code review notes
Testing notes
Checklist: