Skip to content

feat: update overview, pagination, tables, data#37

Merged
Jeday merged 2 commits intodevelopfrom
feat/overview-fixes
Apr 25, 2025
Merged

feat: update overview, pagination, tables, data#37
Jeday merged 2 commits intodevelopfrom
feat/overview-fixes

Conversation

@DiRaiks
Copy link
Copy Markdown
Contributor

@DiRaiks DiRaiks commented Apr 25, 2025

Description

Functional Enhancements:

  • Introduced the useVaultDataTable hook to fetch and process vault data, replacing the older useVaultData hook across various components. This includes calculating health scores and fetching additional vault details. [1] [2] [3]
  • Updated the useVaultsDataAll and useVaultsDataByOwner hooks to use the new useVaultDataTable, improving data handling and adding a vaultsCount property for pagination. [1] [2] [3]
  • Adjusted the VAULTS_PER_PAGE constant to increase the number of vaults displayed per page from 4 to 6.

Vault Table Updates:

  • Modified the VaultTable component to include the vaultsCount prop for accurate title counters and updated column headers to reflect new terminology like "Total value, ETH" and "Health factor." [1] [2]
  • Removed unused columns and added conditional rendering for specific data points in the vault table.

Styling Improvements:

  • Updated the TableTitle styling to dynamically adjust background colors based on theme (dark/light mode) and added a min-width property for better alignment. [1] [2]
  • Created a new MyVaultsWrapper styled component for consistent layout in the "My Vaults" section.

Data Formatting Adjustments:

  • Changed the precision of Ether balances from 5 to 3 decimal places in the EtherCell component and enabled trimming ellipsis for better readability.
  • Adjusted percentage formatting in PercentCell and other contexts to divide values by 100 for proper representation. [1] [2]

Dependency Updates:

  • Updated the @lidofinance/lsv-cli dependency to version 1.0.0-alpha.36 for compatibility with the new health score calculations.

Demo

Code review notes

Testing notes

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@DiRaiks DiRaiks requested a review from a team as a code owner April 25, 2025 10:51
@preview-stands
Copy link
Copy Markdown

preview-stands bot commented Apr 25, 2025

Preview stand status

Stand was demolished

Jeday
Jeday previously approved these changes Apr 25, 2025
Comment thread modules/vaults/hooks/use-vault-data-table.ts Outdated
@Jeday Jeday merged commit 79686d4 into develop Apr 25, 2025
4 of 5 checks passed
@Jeday Jeday deleted the feat/overview-fixes branch April 25, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants