Skip to content

fix: update button text capitalization and improve modal navigation l…#47

Merged
DiRaiks merged 1 commit intodevelopfrom
fix/overview-modal-step
Apr 27, 2025
Merged

fix: update button text capitalization and improve modal navigation l…#47
DiRaiks merged 1 commit intodevelopfrom
fix/overview-modal-step

Conversation

@DiRaiks
Copy link
Copy Markdown
Contributor

@DiRaiks DiRaiks commented Apr 27, 2025

…ogic

Description

User Interface Consistency:

  • Updated button labels to use proper capitalization for better UI consistency (retryRetry, closeClose) in features/create-vault/create-vault-form/submit-modal/submit-modal.tsx and shared/components/submit-modal/submit-modal.tsx. [1] [2]

New "Overview" Step Functionality:

  • Added support for the "overview" step in the getIconComponent and getModalTitle functions to display appropriate icons and titles. [1] [2]
  • Modified the navigation logic to handle the "overview" step by correcting the URL path in the handleNavigateToVault function.

Code Refactoring:

  • Introduced the isShowTxLink variable to simplify conditional rendering of the transaction link, improving code readability. [1] [2]

Demo

Code review notes

Testing notes

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@DiRaiks DiRaiks requested a review from a team as a code owner April 27, 2025 20:50
@preview-stands
Copy link
Copy Markdown

preview-stands bot commented Apr 27, 2025

Preview stand status

Stand was demolished

@DiRaiks DiRaiks merged commit 53d6e85 into develop Apr 27, 2025
3 of 4 checks passed
@DiRaiks DiRaiks deleted the fix/overview-modal-step branch April 27, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants