Fallback in logging when passed object is not json serializable #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdumaine
requested review from
RyanRatcliff,
aecorredor,
evanheisler,
jagoda,
jkdowdle,
rob-snyder,
sternetj and
tomas-phillips-95
jkdowdle
approved these changes
Nov 25, 2025
evanheisler
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when you pass something to the logger that isn't json serializable, it gives up and does a stringified dump of the whole thing. Instead, try to stringify each prop in a couple ways before giving up, so at least the remainder of the log goes through correctly.