Skip to content

Retry queries on interval #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2024
Merged

Retry queries on interval #563

merged 2 commits into from
May 24, 2024

Conversation

bruce-glazier
Copy link
Contributor

Changes

  • Allow specifying the example apps account parameter from the config file
  • Throttle query retries

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9211497699

Details

  • 2 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 84.411%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hooks/useActiveProject.tsx 2 5 40.0%
Totals Coverage Status
Change from base Build 9210511450: -0.09%
Covered Lines: 3902
Relevant Lines: 4487

💛 - Coveralls

) {
query.refetchAll();
}
const intervalId = setInterval(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have logic elsewhere to check for the subject existence? Maybe it would make sense to add an event emitter. Not sure if we have other cases where this might be needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take this is a follow up task after this PR.

@bruce-glazier bruce-glazier merged commit efc6c37 into master May 24, 2024
3 checks passed
@bruce-glazier bruce-glazier deleted the retry-queries-on-interval branch May 24, 2024 14:06
Copy link

🎉 This PR is included in version 12.6.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants