Skip to content

fix: Sleep Chart Bug Fixes #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: Sleep Chart Bug Fixes #565

merged 1 commit into from
Jun 6, 2024

Conversation

sternetj
Copy link
Contributor

@sternetj sternetj commented Jun 6, 2024

Changes

  • Fixes a bug where the start and end dates were null, causing the app to crash
  • Removes data selector on empty charts to prevent empty selection bar/flag
  • Hides stage bar if no components exist. Before the chart would render an misaligned arbitrary bar
  • Fixes a bug where the chart wrapper did not fill the full width of its parent, resulting in the summary view being squished

@coveralls
Copy link

coveralls commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9406327938

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 84.404%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/MyData/SleepChart/MultiDayChart.tsx 1 2 50.0%
Totals Coverage Status
Change from base Build 9290291708: 0.001%
Covered Lines: 3902
Relevant Lines: 4488
💛 - Coveralls

@sternetj sternetj merged commit 72da60e into master Jun 6, 2024
3 checks passed
@sternetj sternetj deleted the sleep-chart-bug-fixes branch June 6, 2024 20:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

🎉 This PR is included in version 12.6.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruce-glazier bruce-glazier bruce-glazier approved these changes

@rob-snyder rob-snyder Awaiting requested review from rob-snyder

Assignees
No one assigned
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sternetj @coveralls @bruce-glazier