LPD-91606 Use namespaced hostname for workspace URLs#277
Merged
Conversation
drewbrokke
requested changes
May 22, 2026
drewbrokke
requested changes
Jun 1, 2026
| } | ||
|
|
||
| environmentMap.put("DL_STORE_CLASS", config.dlStoreClass) | ||
| environmentMap.put("LIFERAY_VALID_HOSTS", config.webserverHostnames.replace(' ', ',')) |
Member
There was a problem hiding this comment.
IIRC, weren't we going to just drop this one until we found a use-case for it? Correct me if I'm wrong here...
…or transforms - print headers directly in template - leverage comma-separation to make whitespace less important in the template - uses "$.Name" for the service name since "$" always anchors to the root object even inside a range - uses a "sed" statement to replace the hyphen with the namespaced link - uses the comma delimiter for the "column" statement - uses "tee /dev/tty" to print the table while continuing the pipeline - uses "grep -q ... &&" to conditionally print - adjusts wording - "project" is the canonical term for a Composer workspace
drewbrokke
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-91606
Workaround at the LEC layer: each workspace gets a distinct
<namespace>.localhosthostname so browser cookies scope per workspace. Doesn't change the underlying RFC 6265 behavior — just stops LEC from steering users into the collision by default. Plainlocalhost:<port>still works for single-workspace use.