Rework FSC Create and Refine GUI #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f github.com:lightly-ai/lightly-studio into horatiu-lig-7767-implement-new-fsc-createedit-wizard
|
|
…f github.com:lightly-ai/lightly-studio into horatiu-lig-7767-implement-new-fsc-createedit-wizard
ikondrat
reviewed
Oct 23, 2025
lightly_studio_view/src/lib/components/FewShotClassifier/ClassifierSamplesGrid.svelte
Outdated
Show resolved
Hide resolved
…f github.com:lightly-ai/lightly-studio into horatiu-lig-7767-implement-new-fsc-createedit-wizard
Contributor
|
after clicking on the refine classifier button until there are no more samples to refine, the wizard gets stuck like this: I think this is because the samples infinite query will get disabled once the backend returns empty positive and negative sample ids, and we should probably update the ClassifierSamplesGrid to account for this too, and show a message saying that all samples have been used or something |
ikondrat
reviewed
Oct 24, 2025
lightly_studio_view/src/lib/components/FewShotClassifier/ClassifierSamplesGrid.svelte
Outdated
Show resolved
Hide resolved
lightly_studio_view/src/lib/components/FewShotClassifier/CreateClassifierDialog.svelte
Show resolved
Hide resolved
lightly_studio_view/src/lib/components/FewShotClassifier/RefineClassifierDialog.svelte
Show resolved
Hide resolved
ikondrat
reviewed
Oct 24, 2025
lightly_studio_view/src/lib/components/FewShotClassifier/ClassifierSamplesGrid.svelte
Outdated
Show resolved
Hide resolved
ikondrat
reviewed
Oct 24, 2025
lightly_studio_view/src/lib/components/FewShotClassifier/ClassifierSamplesGrid.svelte
Outdated
Show resolved
Hide resolved
ikondrat
reviewed
Oct 24, 2025
lightly_studio_view/src/lib/components/FewShotClassifier/ClassifierSamplesGrid.svelte
Outdated
Show resolved
Hide resolved
ikondrat
reviewed
Oct 24, 2025
lightly_studio_view/src/lib/components/FewShotClassifier/ClassifierSamplesGrid.svelte
Outdated
Show resolved
Hide resolved
ikondrat
reviewed
Oct 24, 2025
lightly_studio_view/src/lib/components/FewShotClassifier/ClassifierSamplesGrid.svelte
Outdated
Show resolved
Hide resolved
ikondrat
reviewed
Oct 24, 2025
lightly_studio_view/src/lib/components/FewShotClassifier/ClassifiersMenu.svelte
Show resolved
Hide resolved
ikondrat
reviewed
Oct 24, 2025
lightly_studio_view/src/lib/components/FewShotClassifier/ClassifiersMenu.svelte
Show resolved
Hide resolved
ikondrat
reviewed
Oct 24, 2025
ikondrat
reviewed
Oct 24, 2025
lightly_studio_view/src/lib/hooks/useClassifiers/useClassifiers.ts
Outdated
Show resolved
Hide resolved
ikondrat
reviewed
Oct 24, 2025
lightly_studio_view/src/lib/hooks/useClassifiers/useClassifiers.ts
Outdated
Show resolved
Hide resolved
ikondrat
approved these changes
Oct 24, 2025
Contributor
ikondrat
left a comment
ikondrat
left a comment
There was a problem hiding this comment.
lgtm
all my comments are optional and can be done in follow ups
…f github.com:lightly-ai/lightly-studio into horatiu-lig-7767-implement-new-fsc-createedit-wizard
horatiualmasan
deleted the
horatiu-lig-7767-implement-new-fsc-createedit-wizard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed and why?
Updated the Few shot classifier GUI elements. Create and refine processes are now dialogs above the blurred GUI.
How has it been tested?
Manual tests.
classifier_wizard.mp4
Did you update CHANGELOG.md?