Open
Conversation
guilhermesimoes
commented
Mar 13, 2026
| export type { AnimationSettings } from '../src/core/animations/CoreAnimation.js'; | ||
| export type { TimingFunction } from '../src/core/utils.js'; | ||
| export type { Inspector } from '../src/main-api/Inspector.js'; | ||
| export type { CoreNodeRenderState } from '../src/core/CoreNode.js'; |
Author
There was a problem hiding this comment.
I'd also like to report something here.
Is it intended for consumers of lightningjs/renderer to be able to do:
import { CoreNodeRenderState } from '@lightningjs/renderer';
if (renderState === CoreNodeRenderState.InViewport) { ... }?
Because if so, then this isn't working. All enums are being exported as export declare enum X. In order to preserve enums for consumers, preserveConstEnums must be used.
Contributor
|
@guilhermesimoes I think you aren't approaching that correctly - to create nodes you should be go through the
Both the official Blits and unofficial SolidJS frameworks use this API, and in both cases they don't directly extend those objects, which is potentially a departure from the Lightning 2 approach where you can extend the base Element type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add type exports
TextRenderer,CoreNodePropsandCoreTextNodeProps.Also export
CoreNodeandCoreTextNodesince we can't usestage.createNode()orstage.createTextNode().Peacock has been using Lightning v2's
Elementfor several years now, so all our components extend that class. In order to migrate to Lightning v3, we need access to the new building blocks,CoreNodeandCoreTextNode, so that our components can extend those.