Merged
Conversation
chiefcll
added a commit
that referenced
this pull request
Apr 18, 2025
* get it working with RendererV3 * add solid dev tools * Add KeepAlive demo (#11) * Add KeepAlive demo * Cleanup KeepAlive * Rename to createPersistentComponent, add tsdoc, add detachedOwner * Update KeepAlive documentation * Cleanup createPersistentComponent * update to latest deps * Use lightning/solid as jsxImportSource (#13) Also adds @lightningtv/source customCondition and removes @lightningjs/solid import path (it's unused afaik) * solid-devtools support (#9) * Pass lightning element interface to solid devtools * Update lockfile * Limit vite-hex-transform to src and add more solid devtools plugin options * Use setElementInterface * Update solid-devtools * Add Suspense page and custom suspense component (#16) * Add Suspense page * Implement custom suspense * Add jsdoc to Suspense and handle case when children are falsy --------- Co-authored-by: Damian Tarnawski <gthetarnav@gmail.com>
chiefcll
added a commit
that referenced
this pull request
Jan 15, 2026
* get it working with RendererV3 * add solid dev tools * Add KeepAlive demo (#11) * Add KeepAlive demo * Cleanup KeepAlive * Rename to createPersistentComponent, add tsdoc, add detachedOwner * Update KeepAlive documentation * Cleanup createPersistentComponent * update to latest deps * Use lightning/solid as jsxImportSource (#13) Also adds @lightningtv/source customCondition and removes @lightningjs/solid import path (it's unused afaik) * solid-devtools support (#9) * Pass lightning element interface to solid devtools * Update lockfile * Limit vite-hex-transform to src and add more solid devtools plugin options * Use setElementInterface * Update solid-devtools * Add Suspense page and custom suspense component (#16) * Add Suspense page * Implement custom suspense * Add jsdoc to Suspense and handle case when children are falsy * Remove unnecessary types.ts file (sync with main) (#19) * get working with latest beta-14 of renderer * get working with latest beta * fully working with beta renderer * final touches on rc3 --------- Co-authored-by: Damian Tarnawski <gthetarnav@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on lightning-tv/solid#32 and thetarnav/solid-devtools#345