Tie element with owner lifecycle instead of insert/delete queue #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetarnav
changed the title
chiefcll
reviewed
Apr 8, 2025
Comment on lines
+17
to
20
| let o = s.getOwner(); | ||
| if (o != null) { | ||
| s.onCleanup(el.destroy.bind(el)); | ||
| } |
There was a problem hiding this comment.
Guess my only question / concern would be the performance overhead of this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an experiment.
Deleting the element when the owner disposes would make the current queue logic unnecessary, and also allow for removing elements from the tree, keeping in memory and then re-adding again without deleting the element in the process. Which make using
Suspense,createRootPooland other primitives that keep elements in memory possible.Currently this breaks
onDestroyanimations, because ofnode.parent = undefinedinremoveNode. It is necessary for elements kept in memory to not be displayed, but it also mean that all elements removed are removed immediately without animations.