BOLT 7: Clarify what "gossip messages" are. #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use that term in BOLT 2's retransmission section, to avoid confusion. In particular: a node can't send `announcement_signatures` before both sides have agreed on `funding_locked` and thus consider the short_channel_id a settled matter. Signed-off-by: Rusty Russell <[email protected]>
darosior
reviewed
Oct 30, 2019
| @@ -1123,7 +1123,7 @@ operation, acknowledgments of updates are delayed until the | |||
| that the updates have been received. This also means that the receiving | |||
| node only needs to store updates upon receipt of `commitment_signed`. | |||
|
|
|||
| Note that messages described in [BOLT #7](07-routing-gossip.md) are | |||
| Note that gossip message described in [BOLT #7](07-routing-gossip.md#gossip-messages) are | |||
There was a problem hiding this comment.
nit
Suggested change
| Note that gossip message described in [BOLT #7](07-routing-gossip.md#gossip-messages) are | |
| Note that gossip messages described in [BOLT #7](07-routing-gossip.md#gossip-messages) are |
|
concept ACK, this can supercede #620 as well |
|
|
||
| Certain messages are used to relay information about the state of the | ||
| network, and are not merely generated to send to direct peers. We | ||
| refer to these as "gossip messages". |
There was a problem hiding this comment.
it might be useful to add two entries to BOLT 00 Introduction in the glossary.
-
Lightning message:
- An encrypted message sent between connected peers.
- Foundation of the transport layer of the communication network (defined in BOLT 08)
-
Gossip message:
- Certain types of Lightning Messages that are forwarded to other peers.
niftynei
added
the
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use that term in BOLT 2's retransmission section, to avoid confusion.
In particular: a node can't send
announcement_signaturesbefore both sides have agreed onfunding_lockedand thus consider the short_channel_id a settled matter.Signed-off-by: Rusty Russell [email protected]
Fixes: #620