Skip to content

Add tests and improve documentation for zero reserve channels#873

Open
tankyleo wants to merge 2 commits intolightningdevkit:mainfrom
tankyleo:2026-04-zero-reserve
Open

Add tests and improve documentation for zero reserve channels#873
tankyleo wants to merge 2 commits intolightningdevkit:mainfrom
tankyleo:2026-04-zero-reserve

Conversation

@tankyleo
Copy link
Copy Markdown
Contributor

@tankyleo tankyleo commented Apr 11, 2026

Follow-up to #853

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented Apr 11, 2026 •
edited
Loading

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo tankyleo requested review from benthecarman and tnull April 11, 2026 02:00
@tankyleo
Copy link
Copy Markdown
Contributor Author

tankyleo commented Apr 11, 2026

Let me know how this sounds, is that the testing you had in mind ?

@benthecarman
Copy link
Copy Markdown
Contributor

benthecarman commented Apr 11, 2026 •
edited
Loading

vss tests don't compile but yeah lgtm

@tankyleo tankyleo force-pushed the 2026-04-zero-reserve branch from d3e3e57 to f832421 Compare April 12, 2026 17:54
@tankyleo
Copy link
Copy Markdown
Contributor Author

tankyleo commented Apr 12, 2026

Fixed the VSS tests, and reworked the documentation wording

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented Apr 13, 2026

🔔 1st Reminder

Hey @tnull @benthecarman! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

1 similar comment
@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented Apr 13, 2026

🔔 1st Reminder

Hey @tnull @benthecarman! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull Awaiting requested review from tnull

@benthecarman benthecarman Awaiting requested review from benthecarman

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tankyleo @ldk-reviews-bot @benthecarman