Skip to content

Fix windows-only test failure added in #997 #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

TheBlueMatt
Copy link
Collaborator

This is a trivial bugfix to add a missing test updated required in
PR 997.

@TheBlueMatt TheBlueMatt added this to the 0.0.101 milestone Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #1091 (a233780) into main (2cf42aa) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
+ Coverage   90.72%   90.77%   +0.04%     
==========================================
  Files          65       65              
  Lines       34212    34354     +142     
==========================================
+ Hits        31039    31185     +146     
+ Misses       3173     3169       -4     
Impacted Files Coverage Δ
lightning-persister/src/lib.rs 94.21% <ø> (ø)
lightning/src/ln/functional_tests.rs 97.45% <0.00%> (+0.09%) ⬆️
lightning-block-sync/src/http.rs 94.77% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf42aa...a233780. Read the comment docs.

This is a trivial bugfix to add a missing test updated required in
PR 997.
Copy link

@ariard ariard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a233780

@TheBlueMatt TheBlueMatt merged commit 34dd7c5 into lightningdevkit:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants