Skip to content

Give peers which are sending us messages/receiving messages from us longer to respond to ping #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 28, 2021
Merged

Give peers which are sending us messages/receiving messages from us longer to respond to ping #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
10580f5
Correct send-bounding logic in `TestRoutingMessageHandler`
TheBlueMatt Oct 25, 2021
4a58e9a
Add `PeerManager::disconnect_all_peers` to avoid complexity in BP
TheBlueMatt Oct 26, 2021
e496c9b
Constify the ratio in buf limits between forward and init sync msgs
TheBlueMatt Oct 25, 2021
3f9a7de
Util-ify enqueueing an encoded message in peer_handler
TheBlueMatt Oct 28, 2021
ed4a39f
Give peers which are sending us messages longer to respond to ping
TheBlueMatt Oct 11, 2021
be123f7
Give peers one timer tick to finish handshake before disconnecting
TheBlueMatt Oct 21, 2021
0caa8bb
Log peer public key more thoroughly when logging in peer_handler
TheBlueMatt Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lightning-background-processor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ use lightning::chain::chainmonitor::{ChainMonitor, Persist};
use lightning::chain::keysinterface::{Sign, KeysInterface};
use lightning::ln::channelmanager::ChannelManager;
use lightning::ln::msgs::{ChannelMessageHandler, RoutingMessageHandler};
use lightning::ln::peer_handler::{PeerManager, SocketDescriptor};
use lightning::ln::peer_handler::CustomMessageHandler;
use lightning::ln::peer_handler::{CustomMessageHandler, PeerManager, SocketDescriptor};
use lightning::routing::network_graph::NetGraphMsgHandler;
use lightning::util::events::{Event, EventHandler, EventsProvider};
use lightning::util::logger::Logger;
Expand Down Expand Up @@ -236,8 +235,7 @@ impl BackgroundProcessor {
// timer, we should have disconnected all sockets by now (and they're probably
// dead anyway), so disconnect them by calling `timer_tick_occurred()` twice.
log_trace!(logger, "Awoke after more than double our ping timer, disconnecting peers.");
peer_manager.timer_tick_occurred();
peer_manager.timer_tick_occurred();
peer_manager.disconnect_all_peers();
last_ping_call = Instant::now();
} else if last_ping_call.elapsed().as_secs() > PING_TIMER {
log_trace!(logger, "Calling PeerManager's timer_tick_occurred");
Expand Down
Loading