Store Payee info with HTLCs
#1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1138 +/- ##
==========================================
+ Coverage 90.41% 90.47% +0.06%
==========================================
Files 68 68
Lines 35244 35273 +29
==========================================
+ Hits 31865 31914 +49
+ Misses 3379 3359 -20
Continue to review full report at Codecov.
|
TheBlueMatt
force-pushed
the
2021-10-payee-in-monitors
branch
2 times, most recently
from
6a026ca to
61ed11a
Compare
|
Rebased and fixed fuzz build. |
jkczyz
reviewed
Oct 25, 2021
`Payee` is expected to be used by users to get routes for payment retries, potentially with their own router. Thus, its helpful if it is pub, even if it is redundant with the last hop in the `path` field in `Events::PaymentPathFailed`.
TheBlueMatt
force-pushed
the
2021-10-payee-in-monitors
branch
from
61ed11a to
2a7ed23
Compare
|
Good catch, testing the retry data in the expect macros is super trivial and easy way to get lots of coverage, done. |
arik-so
approved these changes
Oct 25, 2021
This stores and tracks HTLC payee information with HTLCSource info, allowing us to provide it back to the user if the HTLC fails and ensuring persistence by keeping it with the HTLC itself as it passes between Channel and ChannelMonitor.
TheBlueMatt
force-pushed
the
2021-10-payee-in-monitors
branch
from
2a7ed23 to
1b99c93
Compare
|
Squashed without change, will land after CI: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1134, this builds on #1104 and ensures users always get payee information back in
PaymentPathFailedevents.