[lightning-net-tokio] Fix race-y unwrap fetching peer socket address #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently saw the following panic on one of my test nodes:
```
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()`
on an `Err` value: Os { code: 107, kind: NotConnected, message:
"Transport endpoint is not connected" }',
rust-lightning/lightning-net-tokio/src/lib.rs:250:38
```
Presumably what happened is somehow the connection was closed in
between us accepting it and us going to start processing it. While
this is a somewhat surprising race, its clearly reachable. The fix
proposed here is quite trivial - simply don't `unwrap` trying to
fetch our peer's socket address, instead treat the peer address as
`None` and discover the disconnection later when we go to read.
Codecov Report
@@ Coverage Diff @@
## main #1449 +/- ##
==========================================
+ Coverage 90.88% 91.63% +0.74%
==========================================
Files 75 75
Lines 41474 46120 +4646
Branches 41474 46120 +4646
==========================================
+ Hits 37695 42260 +4565
- Misses 3779 3860 +81
Continue to review full report at Codecov.
|
vincenzopalazzo
previously approved these changes
Apr 25, 2022
arik-so
previously approved these changes
Apr 25, 2022
TheBlueMatt
dismissed stale reviews from arik-so, tnull, and vincenzopalazzo
via
9490393
Hmmm, yea, I tried, wrote a test, but it didn't reproduce the issue. I still committed it because maybe there's a world where it does manage to reproduce the issue on some hosts, dunno. |
arik-so
previously approved these changes
Apr 27, 2022
vincenzopalazzo
previously approved these changes
Apr 28, 2022
TheBlueMatt
dismissed stale reviews from vincenzopalazzo and arik-so
via
464175e
dunxen
previously approved these changes
Apr 28, 2022
tnull
previously approved these changes
May 2, 2022
Sadly this does not reproduce the issue fixed in the previous commit.
TheBlueMatt
force-pushed
the
2022-04-fix-remote_ip_race
branch
from
373dfcc to
3f22d81
Compare
|
Squashed fixup commits. |
arik-so
approved these changes
May 3, 2022
jkczyz
reviewed
May 4, 2022
Comment on lines
+650
to
+651
| // This attempts to find other similar races by opening connections and shutting them down | ||
| // while connecting. Sadly in testing this did *not* reproduce the previous issue. |
There was a problem hiding this comment.
Where does the "and shutting them down while connecting" happen?
There was a problem hiding this comment.
We drop the other TcpStream, which should close it.
jkczyz
approved these changes
May 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently saw the following panic on one of my test nodes:
Presumably what happened is somehow the connection was closed in
between us accepting it and us going to start processing it. While
this is a somewhat surprising race, its clearly reachable. The fix
proposed here is quite trivial - simply don't
unwraptrying tofetch our peer's socket address, instead treat the peer address as
Noneand discover the disconnection later when we go to read.