Fix rapid-gossip-sync warning and version number
#1499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
previously approved these changes
May 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #1499 +/- ##
=======================================
Coverage 90.95% 90.95%
=======================================
Files 80 80
Lines 42689 42689
Branches 42689 42689
=======================================
Hits 38827 38827
Misses 3862 3862
Continue to review full report at Codecov.
|
tnull
force-pushed
the
2022-05-fix-unreachable-warning
branch
from
ba81317 to
bdc2a47
Compare
tnull
changed the title
rapid-gossip-sync warning and version number
arik-so
reviewed
May 27, 2022
| @@ -197,6 +197,7 @@ mod tests { | |||
| println!("{}", error_string); | |||
| return; | |||
| } | |||
| #[cfg(require_route_graph_test)] | |||
There was a problem hiding this comment.
Is this necessary? If require_route_graph_test is not active, this line would already not be getting hit to begin with.
arik-so
approved these changes
May 27, 2022
TheBlueMatt
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an
unreachablewarning during tests that was introduced with #1155.