Re-export core2::io or std::io depending on feature flags
#1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1504 +/- ##
==========================================
- Coverage 91.00% 90.98% -0.03%
==========================================
Files 80 80
Lines 43396 43396
Branches 43396 43396
==========================================
- Hits 39494 39482 -12
- Misses 3902 3914 +12
Continue to review full report at Codecov.
|
valentinewallace
previously approved these changes
May 30, 2022
tnull
previously approved these changes
May 31, 2022
lightning/src/lib.rs
Outdated
| @@ -78,9 +78,11 @@ pub mod ln; | |||
| pub mod routing; | |||
|
|
|||
| #[cfg(feature = "std")] | |||
| use std::io; | |||
| /// Re-export of either `core2::io` or `std::io` depending on the `std` feature flag. | |||
There was a problem hiding this comment.
Suggested change
| /// Re-export of either `core2::io` or `std::io` depending on the `std` feature flag. | |
| /// Re-export of either `core2::io` or `std::io`, depending on the `std` feature flag. |
This is useful in bindings as the `lightning::io` module is used in the public interface, but also useful for users who want to refer to the `io` as used in lightning irrespective of the feature flags.
TheBlueMatt
force-pushed
the
2022-05-pub-io
branch
from
c529e4c to
b4a9b96
Compare
|
Seems you need to kick CI? |
tnull
approved these changes
May 31, 2022
jkczyz
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in bindings as the
lightning::iomodule is used inthe public interface, but also useful for users who want to refer
to the
ioas used in lightning irrespective of the feature flags.